WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
279527
[WASM] Incorrect indexing in recursion group when checking subtype validity
https://bugs.webkit.org/show_bug.cgi?id=279527
Summary
[WASM] Incorrect indexing in recursion group when checking subtype validity
David Degazio
Reported
2024-09-11 11:12:25 PDT
rdar://134582688
In the WASM section parser, after we finish parsing a recursion group, we check that all subtype relations for types within the group are valid. Currently, this is done via const TypeDefinition& def = m_info->typeSignatures[i].get().unroll(); However, the i in this case refers to the indices of the list of types in the recursion group, not type indices in the module overall. So if we want to consider the type at index zero of a recursion group starting at, say, 10, we instead get the type zero for the whole module - whichever type was defined first.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2024-09-11 15:05:47 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/33498
EWS
Comment 2
2024-09-12 10:21:49 PDT
Committed
283568@main
(692b33ef1461): <
https://commits.webkit.org/283568@main
> Reviewed commits have been landed. Closing PR #33498 and removing active labels.
EWS
Comment 3
2024-09-12 21:21:29 PDT
Committed
283286.31@safari-7620-branch
(8ef535b99832): <
https://commits.webkit.org/283286.31@safari-7620-branch
> Reviewed commits have been landed. Closing PR #1760 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug