Bug 27951 - [commit+] Invalid assert in v8 SVG bindings (hit during acid3 test).
Summary: [commit+] Invalid assert in v8 SVG bindings (hit during acid3 test).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 13:53 PDT by Dean McNamee
Modified: 2009-08-03 14:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.08 KB, patch)
2009-08-03 13:55 PDT, Dean McNamee 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean McNamee 2009-08-03 13:53:19 PDT 
We're asserting that a PassRefPtr is not NULL, but the pointer has already be taken my assigning it to a refptr.  The patch is simple.  It is already covered by tests.
Comment 1 Dean McNamee 2009-08-03 13:55:28 PDT 
Created attachment 34002 [details]
Patch
Comment 2 Adam Barth 2009-08-03 13:57:41 PDT 
Comment on attachment 34002 [details]
Patch

Thanks dean.
Comment 3 Adam Barth 2009-08-03 13:59:05 PDT 
Will land.
Comment 4 Adam Barth 2009-08-03 14:01:01 PDT 
Comment on attachment 34002 [details]
Patch

Clearing review flag on attachment: 34002

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8SVGPODTypeWrapper.h
Committed r46730
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8SVGPODTypeWrapper.h
r46730 = 40d39dba04f64d485ce7ee3a2141c31d193d805a (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46730
Comment 5 Adam Barth 2009-08-03 14:01:05 PDT 
All reviewed patches have been landed.  Closing bug.