NEW279440
[Skia] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html crashing 
https://bugs.webkit.org/show_bug.cgi?id=279440
Summary [Skia] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/of...
Claudio Saavedra
Reported 2024-09-10 06:33:46 PDT
Regression seems to have started somewhere here: https://github.com/WebKit/WebKit/commit/1bd3d2f0f7e6380b6d9e2e6003dfb2636b51b266 Thread 1 (Thread 0x7f7e7d7fa6c0 (LWP 805415)): #0 0x00007f7fde9343d6 in WebCore::SkiaGLContext::sampleCount() const (this=0x0) at /app/webkit/Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:157 #1 0x00007f7fde9347a5 in WebCore::PlatformDisplay::msaaSampleCount() const (this=0x7f7fb702c500) at /app/webkit/Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:214 #2 0x00007f7fde928abf in WebCore::flushSurfaceIfNeeded(SkSurface*) (surface=0x561c1fb334e0) at /app/webkit/Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp:127 #3 0x00007f7fde928c02 in WebCore::ImageBufferSkiaAcceleratedBackend::createNativeImageReference() (this=0x7f7e1a0617d0) at /app/webkit/Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp:144 #4 0x00007f7fde64f87f in WebCore::ImageBuffer::createNativeImageReference() const (this=0x7f7fb71d6980) at /app/webkit/Source/WebCore/platform/graphics/ImageBuffer.cpp:310 #5 0x00007f7fde61c048 in WebCore::GraphicsContext::nativeImageForDrawing(WebCore::ImageBuffer&) (this=0x7f7fb7c3c130, imageBuffer=...) at /app/webkit/Source/WebCore/platform/graphics/GraphicsContext.cpp:361 #6 0x00007f7fde61c2c5 in WebCore::GraphicsContext::drawImageBuffer(WebCore::ImageBuffer&, WebCore::FloatRect const&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions) (this=0x7f7fb7c3c130, image=..., destination=..., source=..., options=...) at /app/webkit/Source/WebCore/platform/graphics/GraphicsContext.cpp:379 #7 0x00007f7fdd926a03 in WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::ImageBitmap&, WebCore::FloatRect const&, WebCore::FloatRect const&) (this=0x7f7e1a0640b0, imageBitmap=..., srcRect=..., dstRect=...) at /app/webkit/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1952 #8 0x00007f7fdd946653 in operator()<WTF::RefPtr<WebCore::ImageBitmap> >(WTF::RefPtr<WebCore::ImageBitmap, WTF::RawPtrTraits<WebCore::ImageBitmap>, WTF::DefaultRefDerefTraits<WebCore::ImageBitmap> >&) const (__closure=0x7f7e7d7f8020, element=...) at /app/webkit/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1589 #9 0x00007f7fdd9429d6 in std::__invoke_impl<WebCore::ExceptionOr<void>, WTF::Visitor<WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::HTMLImageElement>&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::SVGImageElement, WTF::RawPtrTraits<WebCore::SVGImageElement>, WTF::DefaultRefDerefTraits<WebCore::SVGImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(auto:264&)> >, WTF::RefPtr<WebCore::ImageBitmap, WTF::RawPtrTraits<WebCore::ImageBitmap>, WTF::DefaultRefDerefTraits<WebCore::ImageBitmap> >&>(std::__invoke_other, WTF::Visitor<WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::HTMLImageElement, WTF::RawPtrTraits<WebCore::HTMLImageElement>, WTF::DefaultRefDerefTraits<WebCore::HTMLImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::SVGImageElement, WTF::RawPtrTraits<WebCore::SVGImageElement>, WTF::DefaultRefDerefTraits<WebCore::SVGImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(auto:264&)> > &&) (__f=...) at /usr/include/c++/13.2.0/bits/invoke.h:61 #10 0x00007f7fdd93d9af in std::__invoke<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::HTMLImageElement>&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::SVGImageElement, WTF::RawPtrTraits<WebCore::SVGImageElement>, WTF::DefaultRefDerefTraits<WebCore::SVGImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(auto:264&)> >, WTF::RefPtr<WebCore::ImageBitmap, WTF::RawPtrTraits<WebCore::ImageBitmap>, WTF::DefaultRefDerefTraits<WebCore::ImageBitmap> >&>(WTF::Visitor<WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::HTMLImageElement, WTF::RawPtrTraits<WebCore::HTMLImageElement>, WTF::DefaultRefDerefTraits<WebCore::HTMLImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(WTF::RefPtr<WebCore::SVGImageElement, WTF::RawPtrTraits<WebCore::SVGImageElement>, WTF::DefaultRefDerefTraits<WebCore::SVGImageElement> >&)>, WebCore::CanvasRenderingContext2DBase::drawImage(WebCore::CanvasImageSource&&, float, float)::<lambda(auto:264&)> > &&) (__fn=...) at /usr/include/c++/13.2.0/bits/invoke.h:97 Full stacktrace: https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/283368@main%20(14328)/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w-crash-log.txt
Attachments
Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2024-09-10 06:42:11 PDT
s_skiaGLContext is used initialized it seems?
Claudio Saavedra
Comment 2 2024-09-10 06:42:26 PDT
*unitialized.
Note You need to log in before you can comment on or make changes to this bug.