Bug 27943 - Need to implement ARIA role="radiogroup"
Summary: Need to implement ARIA role="radiogroup"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 09:41 PDT by chris fleizach
Modified: 2009-08-03 12:39 PDT (History)
0 users

See Also:

Attachments
patch (8.05 KB, patch)
2009-08-03 09:52 PDT, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-08-03 09:41:28 PDT 
The ARIA spec defines the radiogroup role as "A group of radio controls." It will probably map to RadioGroupRole.
Comment 1 chris fleizach 2009-08-03 09:52:28 PDT 
Created attachment 33984 [details]
patch
Comment 2 Darin Adler 2009-08-03 10:00:15 PDT 
Comment on attachment 33984 [details]
patch

> +            AccessibilityObject* radioButton = m_object->selectedRadioButton();
> +            if (radioButton)
> +                return radioButton->wrapper();
> +            return nil;

We normally do the early exit for the failure case rather than the success case.

r=me
Comment 3 chris fleizach 2009-08-03 10:14:04 PDT 
http://trac.webkit.org/changeset/46721
Comment 4 chris fleizach 2009-08-03 12:39:22 PDT 
not sure why a layout test in mozilla/tables is failing for intel release after this patch.