In file included from ../JavaScriptCore/interpreter/Register.h:32, from ../JavaScriptCore/jit/JITStubs.h:35, from ../JavaScriptCore/runtime/JSGlobalData.h:34, from ../JavaScriptCore/runtime/Identifier.h:24, from ../WebCore/platform/text/PlatformString.h:35, from ../WebCore/page/Console.h:32, from ../WebCore/page/ChromeClient.h:23, from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:23, from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:24: ../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(JSC::JSCell*)’: ../JavaScriptCore/runtime/JSValue.h:472: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision ../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(const JSC::JSCell*)’: ../JavaScriptCore/runtime/JSValue.h:478: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1 I believe we should set JSVALUE64 instead of JSVALUE32_64 on all X86_64 platform.
Created attachment 33960 [details] 2009-08-02 Xan Lopez <xlopez@igalia.com> Fix the GTK+ build. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46712 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 7 insertions(+), 1 deletions(-)
Created attachment 33961 [details] use JSVALUE64 --- 2 files changed, 12 insertions(+), 1 deletions(-)
Created attachment 33969 [details] use JSVALUE64 for X86_64 LINUX, except Qt --- 2 files changed, 12 insertions(+), 1 deletions(-)
Comment on attachment 33969 [details] use JSVALUE64 for X86_64 LINUX, except Qt r=me.
(In reply to comment #4) > (From update of attachment 33969 [details]) > r=me. Landed as http://trac.webkit.org/changeset/46716.