Bug 27936 - Build fail on ubuntu/x86_64
Summary: Build fail on ubuntu/x86_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-02 23:39 PDT by Fumitoshi Ukai
Modified: 2009-08-03 05:21 PDT (History)
1 user (show)

See Also:

Attachments
2009-08-02 Xan Lopez <xlopez@igalia.com> (937 bytes, patch)
2009-08-02 23:46 PDT, Fumitoshi Ukai 		no flags Details | Formatted Diff | Diff
use JSVALUE64 (1.02 KB, patch)
2009-08-02 23:47 PDT, Fumitoshi Ukai 		no flags Details | Formatted Diff | Diff
use JSVALUE64 for X86_64 LINUX, except Qt (1.05 KB, patch)
2009-08-03 04:26 PDT, Fumitoshi Ukai 		jmalonzo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-08-02 23:39:45 PDT 
In file included from ../JavaScriptCore/interpreter/Register.h:32,
                 from ../JavaScriptCore/jit/JITStubs.h:35,
                 from ../JavaScriptCore/runtime/JSGlobalData.h:34,
                 from ../JavaScriptCore/runtime/Identifier.h:24,
                 from ../WebCore/platform/text/PlatformString.h:35,
                 from ../WebCore/page/Console.h:32,
                 from ../WebCore/page/ChromeClient.h:23,
                 from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:23,
                 from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:24:
../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(JSC::JSCell*)’:
../JavaScriptCore/runtime/JSValue.h:472: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision
../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(const JSC::JSCell*)’:
../JavaScriptCore/runtime/JSValue.h:478: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision
make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1


I believe we should set JSVALUE64 instead of JSVALUE32_64 on all X86_64 platform.
Comment 1 Fumitoshi Ukai 2009-08-02 23:46:52 PDT 
Created attachment 33960 [details]
2009-08-02  Xan Lopez  <xlopez@igalia.com>

Fix the GTK+ build.

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 2 files changed, 7 insertions(+), 1 deletions(-)
Comment 2 Fumitoshi Ukai 2009-08-02 23:47:32 PDT 
Created attachment 33961 [details]
use JSVALUE64


---
 2 files changed, 12 insertions(+), 1 deletions(-)
Comment 3 Fumitoshi Ukai 2009-08-03 04:26:24 PDT 
Created attachment 33969 [details]
use JSVALUE64 for X86_64 LINUX, except Qt


---
 2 files changed, 12 insertions(+), 1 deletions(-)
Comment 4 Jan Alonzo 2009-08-03 05:01:10 PDT 
Comment on attachment 33969 [details]
use JSVALUE64 for X86_64 LINUX, except Qt

r=me.
Comment 5 Jan Alonzo 2009-08-03 05:21:40 PDT 
(In reply to comment #4)
> (From update of attachment 33969 [details])
> r=me.

Landed as http://trac.webkit.org/changeset/46716.