Bug 27934 - [Qt] Consolidate common gcc flags to WebKit.pri
Summary: [Qt] Consolidate common gcc flags to WebKit.pri
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-02 19:35 PDT by Laszlo Gombos
Modified: 2009-08-03 19:14 PDT (History)
1 user (show)

See Also:

proposed patch (3.33 KB, patch)
2009-08-02 19:46 PDT, Laszlo Gombos
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-08-02 19:35:47 PDT
All Qt projects include WebKit.pri, so by moving the common flags to WebKit.pri all projects would share a common baseline. One of the practical use of this is to disable all the unused parameter warnings when TestNetscapePlugin gets build.
Comment 1 Laszlo Gombos 2009-08-02 19:46:54 PDT
Created attachment 33958 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-08-03 09:26:00 PDT
Comment on attachment 33958 [details]
proposed patch

Looks sane enough, so long as everything still builds. :)
Comment 3 Adam Barth 2009-08-03 19:14:28 PDT
Comment on attachment 33958 [details]
proposed patch

Clearing review flag on attachment: 33958

Sending        ChangeLog
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/JavaScriptCore.pro
Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.pro
Sending        WebKit.pri
Transmitting file data ......
Committed revision 46743.
Comment 4 Adam Barth 2009-08-03 19:14:31 PDT
All reviewed patches have been landed.  Closing bug.