Bug 279323 – [LegacySVG] Adding 'id's of pending SVG "resource" references does not work for non-resources

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While going through SVG text test cases in Blink to see any issue and notice we fail this one.

Test Case (from issue tracker): https://jsfiddle.net/33x1rL2b/

^ It does not show any text in output in Safari 17.6 while it does in Chrome Canary 130.

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/6a5978f382eca334bfab56ab7409a71e45a51bca

WebKit Source: https://github.com/WebKit/WebKit/blob/b518f48885b952050847dcfda0a61b946b4efef4/Source/WebCore/svg/SVGTextPathElement.cpp#L163

Here, if we add following, it progress above:

CheckedPtr renderer = this->renderer();
    if (!renderer)
        return;

    if (document().settings().layerBasedSVGEngineEnabled()) {
        renderer->repaint();
        return;
    }

    LegacyRenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);

___


Only bit, I am not sure whether we need to do this for LBSE or not because if not, we can just do below part:

CheckedPtr renderer = this->renderer();
    if (!renderer)
        return;

    LegacyRenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);


___

Just raising so we can fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/135509733>

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/33661

[EWS]

Committed 283675@main (1303a49bf2d3): <https://commits.webkit.org/283675@main>

Reviewed commits have been landed. Closing PR #33661 and removing active labels.