Bug 27929 - [Gtk] macros in webkit.m4 should be defined once only
Summary: [Gtk] macros in webkit.m4 should be defined once only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Jan Alonzo
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-08-02 00:23 PDT by Jan Alonzo
Modified: 2009-08-05 04:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (1.89 KB, patch)
2009-08-02 00:28 PDT, Jan Alonzo
no flags Details | Formatted Diff | Diff
Patch v1 (2.83 KB, patch)
2009-08-05 04:24 PDT, Jan Alonzo
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-08-02 00:23:52 PDT
Macros like WEBKIT_INIT, WEBKIT_CHECK_DEPENDENCIES, etc... should be defined once only as they're not meant to be called multiple times.
Comment 1 Jan Alonzo 2009-08-02 00:28:15 PDT
Created attachment 33946 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-02 15:08:02 PDT
Comment on attachment 33946 [details]
Patch v1

Just gonna trust you here.  rs=me.
Comment 3 Jan Alonzo 2009-08-03 03:50:34 PDT
(In reply to comment #2)
> (From update of attachment 33946 [details])
> Just gonna trust you here.  rs=me.

Thank you. Landed as http://trac.webkit.org/changeset/46714 and 46715.
Comment 4 Xan Lopez 2009-08-05 01:14:33 PDT
I had to revert this, since it was making us build debug images by default...
Comment 5 Xan Lopez 2009-08-05 01:14:51 PDT
Comment on attachment 33946 [details]
Patch v1

Clearing flags.
Comment 6 Jan Alonzo 2009-08-05 03:35:46 PDT
(In reply to comment #4)
> I had to revert this, since it was making us build debug images by default...

Without this patch -g still gets passed on my machine. Are you sure it's this patch that made it build debug images?
Comment 7 Xan Lopez 2009-08-05 03:37:58 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > I had to revert this, since it was making us build debug images by default...
> 
> Without this patch -g still gets passed on my machine. Are you sure it's this
> patch that made it build debug images?

Reverting it worked on my machine, but I guess you can never be sure of anything with autotools :)
Comment 8 Jan Alonzo 2009-08-05 04:07:03 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > I had to revert this, since it was making us build debug images by default...
> > 
> > Without this patch -g still gets passed on my machine. Are you sure it's this
> > patch that made it build debug images?
> 
> Reverting it worked on my machine, but I guess you can never be sure of
> anything with autotools :)

The issue here seems to be that AC_PROG_CXX gets expanded before we're able to set CXXFLAGS and CFLAGS (AC_PROG_CXX adds "-g -O2" if CXXFLAGS/CFLAGS are not defined). So we need to make sure those flags are set before AC_PROG_CXX is expanded.
Comment 9 Jan Alonzo 2009-08-05 04:24:40 PDT
Created attachment 34126 [details]
Patch v1
Comment 10 Xan Lopez 2009-08-05 04:32:47 PDT
Comment on attachment 34126 [details]
Patch v1

OK, makes sense :)
Comment 11 Jan Alonzo 2009-08-05 04:41:08 PDT
(In reply to comment #10)
> (From update of attachment 34126 [details])
> OK, makes sense :)

Landed as http://trac.webkit.org/changeset/46797. Thanks!