Bug 27928 - Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
Summary: Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-01 23:29 PDT by Joseph Pecoraro
Modified: 2009-08-04 00:16 PDT (History)
4 users (show)

See Also:


Attachments
Drawer Support For Multiple Views (111.73 KB, patch)
2009-08-02 00:27 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2009-08-01 23:29:02 PDT
This would make it possible for the Sliding Drawer that currently holds the Console to support multiple views:
http://screencast.com/t/4Cuo618Zbn

This hints at a new "Changes" view, that will likely be opened in a different bug.
Comment 1 Joseph Pecoraro 2009-08-02 00:27:46 PDT
Created attachment 33945 [details]
Drawer Support For Multiple Views

The ChangeLog covers some of the details.  But I'll still throw some notes here.

BEFORE COMMIT:

- Console.js should be renamed to ConsoleView.js in order to preserve the history (good point from Tim).

NOTES:

- Drawer.js handles the Sliding View opening/closing.  It may contain multiple views with their own status bar icons.
- ConsoleView.js one such view.  (Basically the old Console.js)
- ChangesView.js a new view that may be similar to "FireDiff" for Firebug, to show Changes made via the inspector.
- The ChangesView is off in the patch, there are a number of "TODO" items that explicitly mention what needs to be done to enable it.
- Images for the ChangesView are not yet implemented.  There are a number of "TODO" items that explicitly mention which images are needed.
Comment 2 Timothy Hatcher 2009-08-03 14:28:51 PDT
Landed in r46732.
Comment 3 Pavel Feldman 2009-08-04 00:16:52 PDT
(In reply to comment #2)
> Landed in r46732.

Note that there is a special case in InspectorController's showPanel functionality that is treating Console differently than other views (due to its being a drawer). I don't think any action is required wrt this change, just fyi.