RESOLVED FIXED 279237
Mark the unused _fullScreenEnabled SPI as deprecated 
https://bugs.webkit.org/show_bug.cgi?id=279237
Summary Mark the unused _fullScreenEnabled SPI as deprecated
Brent Fulgham
Reported 2024-09-05 17:08:38 PDT
No one should be using the WKPreference class's '_fullScreenEnabled' property. This is no longer used, in favor of 'elementFullscreenEnabled'. I noticed that some older tests still use the deprecated version of this property, so corrected those tests to match. There should be no behavior changes with this correction, since both properties internally modified the same state variable used to control the actual feature.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-09-05 17:08:55 PDT
<rdar://problem/135380328>
Brent Fulgham
Comment 2 2024-09-05 17:12:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/33219
EWS
Comment 3 2024-09-09 13:23:48 PDT
Committed 283360@main (02078e1966d8): <https://commits.webkit.org/283360@main> Reviewed commits have been landed. Closing PR #33219 and removing active labels.
Brent Fulgham
Comment 4 2024-09-09 17:11:45 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/33353
EWS
Comment 5 2024-09-10 09:48:17 PDT
Committed 283421@main (c732501888aa): <https://commits.webkit.org/283421@main> Reviewed commits have been landed. Closing PR #33353 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.