WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
279233
Rename BlockFlowDirection to FlowDirection for better re-use
https://bugs.webkit.org/show_bug.cgi?id=279233
Summary
Rename BlockFlowDirection to FlowDirection for better re-use
fantasai
Reported
2024-09-05 16:02:10 PDT
We currently have a BlockFlowDirection enum for returning the block flow direction: enum class BlockFlowDirection : uint8_t { TopToBottom, BottomToTop, LeftToRight, RightToLeft, }; Renaming it to FlowDirection would allow it to be re-used in additional contexts that need a flow direction--which would also mean that utility functions that compute against it can also be re-used. It's also slightly shorter, so lines using its literals are less likely to wrap awkwardly. The fact that it's about the block axis is generally clear from e.g. the variable names, so we're lot losing any clarity by doing this.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-09-05 16:02:31 PDT
<
rdar://problem/135376714
>
fantasai
Comment 2
2024-09-05 16:06:23 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/33216
EWS
Comment 3
2024-09-05 22:37:51 PDT
Committed
283249@main
(2c4181eb99b6): <
https://commits.webkit.org/283249@main
> Reviewed commits have been landed. Closing PR #33216 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug