Bug 279220 - [GTK] webkit_settings_set_enable_2d_canvas_acceleration fails on s390x
Summary: [GTK] webkit_settings_set_enable_2d_canvas_acceleration fails on s390x
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P3 Normal
Assignee: Michael Catanzaro
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2024-09-05 13:31 PDT by Jeremy Bicha
Modified: 2024-09-12 09:27 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Bicha 2024-09-05 13:31:06 PDT
- WebKitGTK version: 2.45.3 through 2.45.92
- Epiphany version: 46.3, 47.rc etc       
- Distributor: Ubuntu 24.10

One of Epiphany's build tests began failing on s390x once Ubuntu packaged the 2.45 series of webkitgtk. The build completes successfully with webkitgtk 2.44


# Start of embed tests
# Start of ephy-embed-shell tests
----------------------------------- stderr -----------------------------------
MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
libEGL warning: egl: failed to create dri2 screen

** (/<<PKGBUILDDIR>>/obj-s390x-linux-gnu/tests/test-ephy-embed-shell:18073): WARNING **:
 2D canvas acceleration not supported, webkit_settings_set_enable_2d_canvas_acceleration does nothing

I originally reported this issue at https://gitlab.gnome.org/GNOME/epiphany/-/issues/2429 but was directed to file an issue here.

A few other details were mentioned there:

- webkit_settings_set_enable_2d_canvas_acceleration does not work on big endian architectures, because it depends on skia
- webkit_settings_set_enable_2d_canvas_acceleration gets called via webKitSettingsSetProperty when constructing the WebKitSettings
- This needs to be fixed in WebKit. Either it should not warn at all, or should only warn if set manually and not just when setting to the default value
Comment 1 Michael Catanzaro 2024-09-12 08:54:12 PDT
This is now happening on x86_64 as well.
Comment 2 Michael Catanzaro 2024-09-12 08:55:23 PDT
Just kidding, I think I have a cairo build rather than a skia build. Anyway, a good opportunity for me to fix it....
Comment 3 Michael Catanzaro 2024-09-12 09:27:12 PDT
Pull request: https://github.com/WebKit/WebKit/pull/33553