Bug 279220 – [GTK] webkit_settings_set_enable_2d_canvas_acceleration fails on s390x

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jeremy Bicha]

- WebKitGTK version: 2.45.3 through 2.45.92
- Epiphany version: 46.3, 47.rc etc       
- Distributor: Ubuntu 24.10

One of Epiphany's build tests began failing on s390x once Ubuntu packaged the 2.45 series of webkitgtk. The build completes successfully with webkitgtk 2.44


# Start of embed tests
# Start of ephy-embed-shell tests
----------------------------------- stderr -----------------------------------
MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
libEGL warning: egl: failed to create dri2 screen

** (/<<PKGBUILDDIR>>/obj-s390x-linux-gnu/tests/test-ephy-embed-shell:18073): WARNING **:
 2D canvas acceleration not supported, webkit_settings_set_enable_2d_canvas_acceleration does nothing

I originally reported this issue at https://gitlab.gnome.org/GNOME/epiphany/-/issues/2429 but was directed to file an issue here.

A few other details were mentioned there:

- webkit_settings_set_enable_2d_canvas_acceleration does not work on big endian architectures, because it depends on skia
- webkit_settings_set_enable_2d_canvas_acceleration gets called via webKitSettingsSetProperty when constructing the WebKitSettings
- This needs to be fixed in WebKit. Either it should not warn at all, or should only warn if set manually and not just when setting to the default value

[Michael Catanzaro]

This is now happening on x86_64 as well.

[Michael Catanzaro]

Just kidding, I think I have a cairo build rather than a skia build. Anyway, a good opportunity for me to fix it....

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/33553

[EWS]

Committed 283863@main (4844fb011b18): <https://commits.webkit.org/283863@main>

Reviewed commits have been landed. Closing PR #33553 and removing active labels.