RESOLVED FIXED 27915
[commit+] Add a top level build option to control datagrid support 
https://bugs.webkit.org/show_bug.cgi?id=27915
Summary [commit+] Add a top level build option to control datagrid support
Laszlo Gombos
Reported 2009-07-31 20:58:43 PDT
Turn on datagrid support on by default in build-webkit. By adding the option to control datagrid support will also enable the --minimal option to turn datagrid option off.
Attachments
proposed patch. (1.77 KB, patch)
2009-07-31 21:03 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-07-31 21:03:01 PDT
Created attachment 33928 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2009-07-31 21:21:20 PDT
Comment on attachment 33928 [details] proposed patch. OK.
Eric Seidel (no email)
Comment 3 2009-07-31 21:22:00 PDT
Comment on attachment 33928 [details] proposed patch. Should datagrid be on by default?
Laszlo Gombos
Comment 4 2009-07-31 21:30:04 PDT
(In reply to comment #3) > (From update of attachment 33928 [details]) > Should datagrid be on by default? Eric, thanks for the review. I think I have it on by default in the patch. define => "ENABLE_DATAGRID", default => 1
Adam Barth
Comment 5 2009-07-31 23:29:48 PDT
Comment on attachment 33928 [details] proposed patch. Clearing review flag on attachment: 33928 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit Committed r46662 M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit r46662 = 4350e2dffbf736a02d1b8fa1509acffa1b61fbc4 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46662
Adam Barth
Comment 6 2009-07-31 23:29:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.