Bug 27915 - [commit+] Add a top level build option to control datagrid support
Summary: [commit+] Add a top level build option to control datagrid support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 20:58 PDT by Laszlo Gombos
Modified: 2009-07-31 23:29 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch. (1.77 KB, patch)
2009-07-31 21:03 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-07-31 20:58:43 PDT 
Turn on datagrid support on by default in build-webkit. By adding the option to control datagrid support will also enable the --minimal option to turn datagrid option off.
Comment 1 Laszlo Gombos 2009-07-31 21:03:01 PDT 
Created attachment 33928 [details]
proposed patch.
Comment 2 Eric Seidel (no email) 2009-07-31 21:21:20 PDT 
Comment on attachment 33928 [details]
proposed patch.

OK.
Comment 3 Eric Seidel (no email) 2009-07-31 21:22:00 PDT 
Comment on attachment 33928 [details]
proposed patch.

Should datagrid be on by default?
Comment 4 Laszlo Gombos 2009-07-31 21:30:04 PDT 
(In reply to comment #3)
> (From update of attachment 33928 [details])
> Should datagrid be on by default?

Eric, thanks for the review. I think I have it on by default in the patch.

define => "ENABLE_DATAGRID", default => 1
Comment 5 Adam Barth 2009-07-31 23:29:48 PDT 
Comment on attachment 33928 [details]
proposed patch.

Clearing review flag on attachment: 33928

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/build-webkit
Committed r46662
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/build-webkit
r46662 = 4350e2dffbf736a02d1b8fa1509acffa1b61fbc4 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46662
Comment 6 Adam Barth 2009-07-31 23:29:51 PDT 
All reviewed patches have been landed.  Closing bug.