RESOLVED FIXED279125
Simplify `isSVGRenderer()` in `RenderObject.h` 
https://bugs.webkit.org/show_bug.cgi?id=279125
Summary Simplify `isSVGRenderer()` in `RenderObject.h`
Ahmad Saleem
Reported 2024-09-04 05:12:40 PDT
Hi Team, Just noticed following in RenderObject.h: WebKit Source: https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/rendering/RenderObject.h#602 Current: bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isLegacyRenderSVGModelObject() || isRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); } Where: isLegacyRenderSVGModelObject() || isRenderSVGModelObject() -> can be replaced with (isRenderOrLegacyRenderSVGModelObject()) Which in turn will make `isSVGRenderer` as: bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isRenderOrLegacyRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); } ___ Just raising so we can do this clean-up. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Fady Farag
Comment 1 2024-09-04 16:01:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/33147
EWS
Comment 2 2024-09-06 14:50:09 PDT
Committed 283279@main (78a12607073a): <https://commits.webkit.org/283279@main> Reviewed commits have been landed. Closing PR #33147 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-09-06 14:51:16 PDT
<rdar://problem/135442411>
Note You need to log in before you can comment on or make changes to this bug.