check-wekbit-style uses the diff on the single commit to get the lines changes so it can filter error messages. The problem is that the lines changed in the commit may have moved since the commit was done, so the filtering is incorrect. This fix is uses the commit given as the starting point and the current directory state as the ending point.
Created attachment 33919 [details] Proposed fix.
Comment on attachment 33919 [details] Proposed fix. > + commitish = flags["--git-commit"] > + if commitish.find('..'): > + # FIXME: If the range is a "...", the code should find the common ancesto, > + # do the diff from there. Not sure I understand this FIXME. And you mean 'ancestoR', right?
Created attachment 33921 [details] Proposed fix. Addressed some coding issues mention by Eric. Fixed the spelling issue and tried to clarify the issue mentioned by Adam.
http://trac.webkit.org/changeset/46652