Bug 27896 - Favicons are still loaded when automatic image loading is disabled.
Summary: Favicons are still loaded when automatic image loading is disabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-07-31 15:37 PDT by Brady Eidson
Modified: 2009-07-31 16:22 PDT (History)
0 users

See Also:


Attachments
Fix, DRT enhancements, and layout test. (12.60 KB, patch)
2009-07-31 15:59 PDT, Brady Eidson
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2009-07-31 15:37:45 PDT
Favicons are still loaded when automatic image loading is disabled.
Comment 1 Brady Eidson 2009-07-31 15:37:59 PDT
In radar as <rdar://problem/6973106>
Comment 2 Brady Eidson 2009-07-31 15:59:17 PDT
Created attachment 33905 [details]
Fix, DRT enhancements, and layout test.
Comment 3 John Sullivan 2009-07-31 16:13:44 PDT
Comment on attachment 33905 [details]
Fix, DRT enhancements, and layout test.

Maybe add a line that explains why site icons are tied together with images on the page in this way, such as "People who want to avoid loading images generally want to avoid loading all images."
Comment 4 Brady Eidson 2009-07-31 16:22:32 PDT
Sending        LayoutTests/ChangeLog
Adding         LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt
Adding         LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html
Sending        WebCore/ChangeLog
Sending        WebCore/loader/FrameLoader.cpp
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/LayoutTestController.cpp
Sending        WebKitTools/DumpRenderTree/LayoutTestController.h
Sending        WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
Sending        WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
Sending        WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Sending        WebKitTools/DumpRenderTree/qt/jsobjects.cpp
Sending        WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
Sending        WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Transmitting file data ..............
Committed revision 46646.