Bug 278905 – build-webkit failed for tvOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chenfeng Pan]

According to [README](https://github.com/WebKit/WebKit/blob/main/ReadMe.md#embedded-builds), I try to build tvOS version by `build-webkit --debug --tvos-simulator`. After a while, I got "BUILD FAILED" result reporting 
> The following build commands failed:
>	CompileC ~/WebKit/WebKitBuild/libwebrtc.build/Debug-appletvsimulator/vpx.build/Objects-normal/x86_64/vp9_highbd_iht8x8_add_sse4.o >~/WebKit/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/x86/vp9_highbd_iht8x8_add_sse4.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler (in target 'vpx' from project >'libwebrtc')
>(1 failure)

For details, all errors are similar to "~/WebKit/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/x86/vp9_highbd_iht8x8_add_sse4.c:41:12: error: always_inline function '_mm_mul_epi32' requires target feature 'sse4.1', but would be inlined into function 'highbd_iadst_butterfly_sse4_1' that is compiled without support for 'sse4.1'".

BTW, my device is MacBook Pro(Intel), and os version is sonoma 14.6.1

[Alexey Proskuryakov]

Looks like we only build for arm64 sim in webkit.org CI. However, it's surprising to me that there's compilation happening in a context where sse4.1 is not supported.

[Chenfeng Pan]

(In reply to Alexey Proskuryakov from comment #1)
> Looks like we only build for arm64 sim in webkit.org CI. However, it's
> surprising to me that there's compilation happening in a context where
> sse4.1 is not supported.

My laptop is MacBook Pro 2019(intel i7), which is definitely support SSE4.1. Maybe there is some wrong configuration for x86_64 simulator?

[Chenfeng Pan]

hi, is there any suggestion or update?

[Alexey Proskuryakov]

It will likely be a while before someone takes a look, tvOS Simulator on Intel build is not of the highest priority.

If you need it for some reason, perhaps disabling WebRTC and removing it from the build would unblock you?

[Chenfeng Pan]

(In reply to Alexey Proskuryakov from comment #4)
> It will likely be a while before someone takes a look, tvOS Simulator on
> Intel build is not of the highest priority.
> 
> If you need it for some reason, perhaps disabling WebRTC and removing it
> from the build would unblock you?

I already figured out the reason. xcconfig in WebRTC exclude some source files related to sse feature when targeting to iphonesimulator but without take appletvsimulator into consideration.

I will make a pull-request later.

[Radar WebKit Bug Importer]

<rdar://problem/135399543>

[Chenfeng Pan]

Pull request: https://github.com/WebKit/WebKit/pull/33397

[EWS]

Committed 283431@main (1f3590659941): <https://commits.webkit.org/283431@main>

Reviewed commits have been landed. Closing PR #33397 and removing active labels.