Bug 27886 - Build QtWebKit without benchmark tests for Qt < 4.5
Summary: Build QtWebKit without benchmark tests for Qt < 4.5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 09:36 PDT by Jakob Petsovits
Modified: 2009-07-31 09:55 PDT (History)
0 users

See Also:


Attachments
Build QtWebKit without benchmark tests for Qt < 4.5 (1.09 KB, patch)
2009-07-31 09:40 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Build QtWebKit without benchmark tests for Qt < 4.5 (try 2) (1.09 KB, patch)
2009-07-31 09:43 PDT, Jakob Petsovits
manyoso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2009-07-31 09:36:24 PDT
On one of my systems, I accidentally had Qt 4.4 installed, and decided to build the Qt port there. The QBENCHMARK macro is only available from 4.5 on though, and test files making use of QBENCHMARK are included unconditionally at the moment. The patch below fixes this, and makes WebKit/qt/tests compile with 4.4 again.
Comment 1 Jakob Petsovits 2009-07-31 09:40:24 PDT
Created attachment 33883 [details]
Build QtWebKit without benchmark tests for Qt < 4.5
Comment 2 Jakob Petsovits 2009-07-31 09:43:10 PDT
Created attachment 33884 [details]
Build QtWebKit without benchmark tests for Qt < 4.5 (try 2)

Don't end a sentence with two periods, only one.
Comment 3 Jakob Petsovits 2009-07-31 09:55:35 PDT
Landed by Kenneth Rohde Christiansen with r46632.