Bug 27876 - Expose the Offline Web Application Cache API in the Qt API
Summary: Expose the Offline Web Application Cache API in the Qt API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 05:44 PDT by Kenneth Rohde Christiansen
Modified: 2009-07-31 06:30 PDT (History)
1 user (show)

See Also:


Attachments
Add API to Qt for exposing the webcache (5.07 KB, patch)
2009-07-31 05:44 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2009-07-31 05:44:42 PDT
Created attachment 33873 [details]
Add API to Qt for exposing the webcache

We need to expose the offline web app cache in the Qt API, so that users can at least set some sane defaults for their applications.
Comment 1 Tor Arne Vestbø 2009-07-31 06:22:37 PDT
Comment on attachment 33873 [details]
Add API to Qt for exposing the webcache

looks good, but we have to do an api review of all of this offline/cache stuff before the release. a few nitpicks:

> @@ -358,7 +358,6 @@ QWebSettings::QWebSettings()
>      d->attributes.insert(QWebSettings::LocalStorageDatabaseEnabled, true);
>      d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls, true);
>      d->offlineStorageDefaultQuota = 5 * 1024 * 1024;
> -
>  }

Whitespace change, please remove.

> @@ -785,10 +784,17 @@ qint64 QWebSettings::offlineStorageDefaultQuota()
>  }
>  
>  /*
> -    \internal
> +    \since 4.6
>      \relates QWebSettings
>  
>      Sets the path for HTML5 offline web application cache storage to \a path.

Please add linebreak here.

> +    An application cache acts like an HTTP cache in some sense. For documents
> +    that use the application cache via JavaScript, the loader mechinery will
> +    first ask the application cache for the contents, before hitting the
> +    network.
Comment 2 Kenneth Rohde Christiansen 2009-07-31 06:30:37 PDT
Comment on attachment 33873 [details]
Add API to Qt for exposing the webcache

Landed in 46628