Bug 27875 - Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
Summary: Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 05:00 PDT by Zoltan Horvath
Modified: 2009-08-05 23:58 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (1.16 KB, patch)
2009-07-31 05:04 PDT, Zoltan Horvath
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-31 05:00:25 PDT
Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.
Comment 1 Zoltan Horvath 2009-07-31 05:04:50 PDT
Created attachment 33872 [details]
proposed patch
Comment 2 Adam Barth 2009-08-01 21:39:44 PDT
Oliver: Here's the another patch similar to the one you didn't like.  Would you like to double check it?
Comment 3 Adam Barth 2009-08-05 23:28:07 PDT
Comment on attachment 33872 [details]
proposed patch

As is this one.
Comment 4 Adam Barth 2009-08-05 23:58:00 PDT
Comment on attachment 33872 [details]
proposed patch

Clearing review flag on attachment: 33872

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/parser/Nodes.h
Committed r46837
	M	LayoutTests/platform/gtk/Skipped
	M	LayoutTests/ChangeLog
r46836 = 75353465f722f91d89afde0ce2a14f7179576a66 (trunk)
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/parser/Nodes.h
r46837 = c4b3d98c6a56bb0a0b54922f9c686624656ddf8e (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46837
Comment 5 Adam Barth 2009-08-05 23:58:06 PDT
All reviewed patches have been landed.  Closing bug.