Bug 27870 - isContentEditable function in htmlediting.* can be removed
Summary: isContentEditable function in htmlediting.* can be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P4 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 00:56 PDT by Ryosuke Niwa
Modified: 2009-08-01 23:52 PDT (History)
2 users (show)

See Also:

Attachments
removes the function (6.41 KB, patch)
2009-07-31 11:24 PDT, Ryosuke Niwa 		adele: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2009-07-31 00:56:16 PDT 
isContentEditable function is added in http://trac.webkit.org/changeset/19452 to accomplish
enclosingNodeOfType(node, &isContentEditable)
but this seems to be equivalent to node->isContentEditable() today.
Comment 1 Ryosuke Niwa 2009-07-31 11:24:51 PDT 
Created attachment 33889 [details]
removes the function
Comment 2 Adele Peterson 2009-07-31 11:32:09 PDT 
Comment on attachment 33889 [details]
removes the function

My only comment is that the title of this bug could be "isContentEditable function in htmlediting.* can be removed" instead of "must", but that doesn't really matter.
Comment 3 Justin Garcia 2009-07-31 11:45:21 PDT 
Clarified with Ryosuke.  We're only ever using enclosingNodeOfType(node, &isContentEditable) to determine the editability of node.  So it's OK to remove.
Comment 4 Ryosuke Niwa 2009-08-01 23:52:12 PDT 
Landed in http://trac.webkit.org/changeset/46681.