Bug 27865 - selectionHasStyle needs clean up to fix Bug 27858
Summary: selectionHasStyle needs clean up to fix Bug 27858
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 27858
  Show dependency treegraph
 
Reported: 2009-07-30 18:54 PDT by Ryosuke Niwa
Modified: 2009-08-04 00:33 PDT (History)
2 users (show)

See Also:


Attachments
cleans up selectionHasStyle and selectionStartHasStyle (61.66 KB, patch)
2009-07-30 19:03 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
deleted irrelevant tests. (6.79 KB, patch)
2009-07-30 19:04 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
fixed typo (6.76 KB, patch)
2009-07-30 19:10 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Added the reason this patch does not need tests (8.10 KB, patch)
2009-07-31 18:35 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2009-07-30 18:54:43 PDT
ditto.
Comment 1 Ryosuke Niwa 2009-07-30 19:03:25 PDT
Created attachment 33853 [details]
cleans up selectionHasStyle and selectionStartHasStyle
Comment 2 Ryosuke Niwa 2009-07-30 19:04:52 PDT
Created attachment 33854 [details]
deleted irrelevant tests.
Comment 3 Ryosuke Niwa 2009-07-30 19:10:14 PDT
Created attachment 33855 [details]
fixed typo
Comment 4 Eric Seidel (no email) 2009-07-31 14:16:44 PDT
Comment on attachment 33855 [details]
fixed typo

+        The change is not testable.

Why?  Because there are no functional changes?  You should say that.
Comment 5 Ryosuke Niwa 2009-07-31 18:35:50 PDT
Created attachment 33917 [details]
Added the reason this patch does not need tests
Comment 6 Eric Seidel (no email) 2009-08-03 17:39:15 PDT
Comment on attachment 33917 [details]
Added the reason this patch does not need tests

OK.
Comment 7 Ryosuke Niwa 2009-08-04 00:33:46 PDT
Landed in http://trac.webkit.org/changeset/46749.