Bug 27863 - Consolidate GeoLocation code to send positions and errors
Summary: Consolidate GeoLocation code to send positions and errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Greg Bolsinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 17:45 PDT by Greg Bolsinga
Modified: 2009-07-31 10:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch implementing the change (6.17 KB, patch)
2009-07-30 17:48 PDT, Greg Bolsinga 		staikos: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-07-30 17:45:35 PDT 
There is some redundancy in this code that can be cleaned up.
Comment 1 Greg Bolsinga 2009-07-30 17:48:43 PDT 
Created attachment 33850 [details]
Patch implementing the change
Comment 2 George Staikos 2009-07-31 07:31:22 PDT 
Comment on attachment 33850 [details]
Patch implementing the change

Nice cleanup!
Comment 3 Greg Bolsinga 2009-07-31 10:04:33 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/Geolocation.cpp
	M	WebCore/page/Geolocation.h
Committed r46633