RESOLVED FIXED278612
[LFC][Integration] Add support for calling min/maxPreferredLogicalWidth from inside LFC 
https://bugs.webkit.org/show_bug.cgi?id=278612
Summary [LFC][Integration] Add support for calling min/maxPreferredLogicalWidth from ...
alan
Reported 2024-08-24 15:09:54 PDT
ssia
Attachments
Patch (28.14 KB, patch)
2024-08-24 15:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (28.86 KB, patch)
2024-08-24 15:41 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (41.40 KB, patch)
2024-08-25 08:28 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-08-24 15:39:30 PDT
Created attachment 472285 [details] Patch
alan
Comment 2 2024-08-24 15:41:14 PDT
Created attachment 472286 [details] Patch
alan
Comment 3 2024-08-25 08:28:21 PDT
Created attachment 472288 [details] [fast-cq]Patch
Antti Koivisto
Comment 4 2024-08-26 05:59:09 PDT
Comment on attachment 472288 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472288&action=review > Source/WebCore/layout/LayoutState.cpp:46 > +LayoutState::LayoutState(const Document& document, const ElementBox& rootContainer, Type type, FormattingContextLayoutFunction&& formattingContextLayoutFunction, FormattingContextPreferredWidthsFunction&& formattingContextPreferredWidthsFunction) > : m_type(type) This is bit unwieldy, especially if we keep needing more. We should probably have some sort of abstract formatting context (?) class with virtual functions.
alan
Comment 5 2024-08-26 07:10:12 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 472288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=472288&action=review > > > Source/WebCore/layout/LayoutState.cpp:46 > > +LayoutState::LayoutState(const Document& document, const ElementBox& rootContainer, Type type, FormattingContextLayoutFunction&& formattingContextLayoutFunction, FormattingContextPreferredWidthsFunction&& formattingContextPreferredWidthsFunction) > > : m_type(type) > > This is bit unwieldy, especially if we keep needing more. We should probably > have some sort of abstract formatting context (?) class with virtual > functions. Yeah, actually there's a FormattingContext base class but it is still tied to the LFC only codepath (and I detached IFC from it like a year ago to be able to do some cleanup and focus on integration codepath)
EWS
Comment 6 2024-08-26 07:16:35 PDT
Committed 282729@main (7dd08f57f28b): <https://commits.webkit.org/282729@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472288 [details].
Radar WebKit Bug Importer
Comment 7 2024-08-26 07:17:17 PDT
<rdar://problem/134699824>
Note You need to log in before you can comment on or make changes to this bug.