Bug 27861 - [commit+] [Chromium] remove ChromeClientChromium::setToolTip()
Summary: [commit+] [Chromium] remove ChromeClientChromium::setToolTip()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 15:42 PDT by Xiaomei Ji
Modified: 2009-07-31 23:11 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.41 KB, patch)
2009-07-30 16:00 PDT, Xiaomei Ji 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaomei Ji 2009-07-30 15:42:11 PDT 
This is a follow-up of Webkit patch for issue 24187 -- RTL: tooltip does not get its directionality from its element's directionality.

In the above patch, Webkit passed in both tooltip text and  its element directionality to client.
To make Chromium build OK after the signature change in Webkit, an overloaded virtual function ChromeClientChromium::setToolTip(const String&, TextDirection) was introduced.

Now since Chrome changed its signature in its Webkit glue layer (ChromeClientImpl::setToolTip()), the overloaded ChromeClientChromium::setToolTip() is no longer needed.
Comment 1 Xiaomei Ji 2009-07-30 16:00:13 PDT 
Created attachment 33847 [details]
patch
Comment 2 Adam Barth 2009-07-31 23:11:04 PDT 
Appears to have already been landed.  Please close the bug when you land something.