WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278591
Align 'SVGGeometryElement::getPointAtLength' as per web specification order
https://bugs.webkit.org/show_bug.cgi?id=278591
Summary
Align 'SVGGeometryElement::getPointAtLength' as per web specification order
Ahmad Saleem
Reported
2024-08-23 17:04:18 PDT
Hi Team, Based on feedback from Anne on this PR:
https://github.com/WebKit/WebKit/pull/32623#pullrequestreview-2257548433
I noticed that this is applicable on another function as well. In the spec (
https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement
), it is as follow: 1. If current element is a non-rendered element, and the UA is not able to compute the total length of the path, then throw an InvalidStateError. 2. Let length be the user agent's computed value for the total length of the path, in user units. As with getTotalLength, this does not take into account the ‘pathLength’ attribute. 3. Clamp distance to [0, length]. 4. Let (x, y) be the point on the path at distance distance. 5. Return a newly created, detached DOMPoint object representing the point (x, y). __ So clamping come after 'if the current element...' case, so this bug is to change that and it does not affect anything else. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-08-23 17:04:45 PDT
<
rdar://problem/134596316
>
Ahmad Saleem
Comment 2
2024-08-23 17:11:50 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32656
EWS
Comment 3
2024-08-24 00:15:05 PDT
Committed
282698@main
(f2291919b015): <
https://commits.webkit.org/282698@main
> Reviewed commits have been landed. Closing PR #32656 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug