WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278575
Use `=default` for destructors in `rendering` code
https://bugs.webkit.org/show_bug.cgi?id=278575
Summary
Use `=default` for destructors in `rendering` code
Ahmad Saleem
Reported
2024-08-23 13:33:23 PDT
SSIA We have bunch of these: RenderListMarker::~RenderListMarker() { // Do not add any code here. Add it to willBeDestroyed() instead. } I think we should align with other code base and just change them to: // Do not add any code in below destructor. Add it to willBeDestroyed() instead. RenderVideo::~RenderVideo() = default; Just a reference.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-08-23 13:34:25 PDT
<
rdar://problem/134586310
>
Ahmad Saleem
Comment 2
2024-08-23 13:39:59 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32643
EWS
Comment 3
2024-08-23 17:18:08 PDT
Committed
282685@main
(bc7d339835a5): <
https://commits.webkit.org/282685@main
> Reviewed commits have been landed. Closing PR #32643 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug