WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 27857
clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857
Summary
clean up build-webkit to use less copy/paste code and remove unneeded SVG war...
Eric Seidel (no email)
Reported
2009-07-30 14:42:26 PDT
clean up build-webkit to use less copy/paste code and remove unneeded SVG warning We no longer really need to warn about builds having SVG or not, now that SVG is turned on by default. Also found some copy/paste code which I abstracted a little.
Attachments
Patch v1
(4.03 KB, patch)
2009-07-30 14:43 PDT
,
Eric Seidel (no email)
levin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-07-30 14:43:02 PDT
Created
attachment 33842
[details]
Patch v1
Eric Seidel (no email)
Comment 2
2009-07-30 14:43:41 PDT
The patch is almost all minus lines.
David Levin
Comment 3
2009-07-30 16:57:39 PDT
Comment on
attachment 33842
[details]
Patch v1 I don't normally r+ perl, but this one is simple enough for me to verify.
Eric Seidel (no email)
Comment 4
2009-07-31 14:14:17 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit Committed
r46641
M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit
r46641
= 1ec97c4a8a6ff284eab75001b40068e8d0a95c1f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46641
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug