WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278529
[webkitpy] Add LTR and RTL to list of allowed common enum abbreviations
https://bugs.webkit.org/show_bug.cgi?id=278529
Summary
[webkitpy] Add LTR and RTL to list of allowed common enum abbreviations
Christian Liebel
Reported
2024-08-22 10:35:09 PDT
check-webkit-style does not allow the values "LTR" and "RTL" to appear in enums (rule "readability/enum_casing"):
> enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.
In a pull request, it was discussed that the allowlist should include those two values: *
https://github.com/WebKit/WebKit/pull/30634#discussion_r1723324893
*
https://github.com/WebKit/WebKit/pull/30634#discussion_r1727244189
Attachments
Add attachment
proposed patch, testcase, etc.
Christian Liebel
Comment 1
2024-08-22 10:41:41 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32598
Radar WebKit Bug Importer
Comment 2
2024-08-29 10:36:14 PDT
<
rdar://problem/134949318
>
EWS
Comment 3
2025-06-04 03:08:33 PDT
Committed
295803@main
(f5f1f02036a7): <
https://commits.webkit.org/295803@main
> Reviewed commits have been landed. Closing PR #32598 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug