Bug 27852 - Add --minimal option to webkit-build
Summary: Add --minimal option to webkit-build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 12:45 PDT by Jakob Petsovits
Modified: 2009-07-30 13:57 PDT (History)
1 user (show)

See Also:


Attachments
Add --minimal option to webkit-build (2.08 KB, patch)
2009-07-30 12:49 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Add --minimal option to webkit-build (try 2) (2.16 KB, patch)
2009-07-30 12:53 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Add --minimal option to webkit-build (try 3) (2.16 KB, patch)
2009-07-30 13:08 PDT, Jakob Petsovits
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2009-07-30 12:45:46 PDT
Instead of disabling all optional features with --no-svg, --no-video, --no-xslt, etc., it would be nice to disable all of those at once and only get those options that were explicitely enabled. My relationship to Perl is not the most loving one, but here's a patch anyways. Please review, thanks!
Comment 1 Jakob Petsovits 2009-07-30 12:49:12 PDT
Created attachment 33807 [details]
Add --minimal option to webkit-build
Comment 2 Jakob Petsovits 2009-07-30 12:53:04 PDT
Created attachment 33808 [details]
Add --minimal option to webkit-build (try 2)

New version, this one gets the --minimal option out of @ARGV and thus makes it work with subsequent code that makes use of @ARGV still, like Qt's qmake stuff.
Comment 3 Jakob Petsovits 2009-07-30 13:08:19 PDT
Created attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

Fix for a spelling issue, pointed out by Adam Treat: explicitely -> explicitly.
Comment 4 Adam Roben (:aroben) 2009-07-30 13:17:13 PDT
Comment on attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

I think it would be better and clearer for --minimal to be parsed like all the other options. After the GetOptions call, if $minimal is true you can just loop over @features and set all the values that don't match the default to 0.
Comment 5 Adam Roben (:aroben) 2009-07-30 13:41:36 PDT
Comment on attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

Jakob convinced me that my suggested approach is not better.

r=me
Comment 6 Adam Treat 2009-07-30 13:57:55 PDT
Landed with r46597.