Bug 27846 - MessageEvent should not be cancelable by default
Summary: MessageEvent should not be cancelable by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 11:58 PDT by Andrew Wilson
Modified: 2009-09-15 14:58 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (3.19 KB, patch)
2009-09-14 18:03 PDT, Andrew Wilson
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-07-30 11:58:10 PDT
Currently, all MessageEvents are cancelable by default, but all of the uses in the HTML5 spec specify that it should not be. For example (from the spec for window.postMessage):

"Create an event that uses the MessageEvent interface, with the event name message, which does not bubble, is not cancelable, and has no default action."
Comment 1 Andrew Wilson 2009-09-14 18:03:53 PDT
Created attachment 39583 [details]
proposed patch
Comment 2 WebKit Commit Bot 2009-09-14 18:34:28 PDT
Comment on attachment 39583 [details]
proposed patch

Rejecting patch 39583 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 3 Eric Seidel (no email) 2009-09-15 10:45:12 PDT
Comment on attachment 39583 [details]
proposed patch

media/video-source-error.html -> timed out
You've been bit by flakey media tests. :(  bug 28624.  Hopefully I'll get a chance to look at fixing that after perf stuff today.
Comment 4 Andrew Wilson 2009-09-15 10:54:27 PDT
OK, I'm ready to manually commit it anyway - if the commit-queue fails again I'll just manually commit.

When I get a commit-queue failure, is there any way for me to tell what the failure was?
Comment 5 WebKit Commit Bot 2009-09-15 10:57:57 PDT
Comment on attachment 39583 [details]
proposed patch

Rejecting patch 39583 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 6 Andrew Wilson 2009-09-15 11:28:08 PDT
Landed manually as r48395.
Comment 7 Eric Seidel (no email) 2009-09-15 14:58:41 PDT
http/tests/xmlhttprequest/cross-origin-authorization.html -> failed
Maybe that was flakey?  I think it might be related...