WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278375
Remove Quirk shouldHideSearchFieldResultsButton for *google.*
https://bugs.webkit.org/show_bug.cgi?id=278375
Summary
Remove Quirk shouldHideSearchFieldResultsButton for *google.*
Karl Dubost
Reported
2024-08-20 01:47:25 PDT
<
rdar://75792913
>
Attachments
Add attachment
proposed patch, testcase, etc.
Karl Dubost
Comment 1
2024-08-20 01:53:26 PDT
1. Open Safari iOS 2. Go to
https://www.google.com/
3. Open Safari on macOS 4. Plug your mobile phone to your laptop with a USB cable 5. Develop → Choose the name of your device → Choose www.google.com 3. click on the little icon on the top left inside the Web inspector 4. Choose Disable site specific hacks Reload the page. Does it show two magnifiers or only one? if only one, this is fixed. I believe in my tests that this is fixed and that we can remove the quirk. See the code to be removed.
https://searchfox.org/wubkat/search?q=shouldHideSearchFieldResultsButton&path=&case=false®exp=false
Karl Dubost
Comment 2
2024-10-04 00:59:02 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/34685
EWS
Comment 3
2024-10-04 02:22:28 PDT
Committed
284672@main
(124527c205a0): <
https://commits.webkit.org/284672@main
> Reviewed commits have been landed. Closing PR #34685 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug