RESOLVED INVALID Bug 27834
[commit+] Allow custom memory allocation control for JavaScriptCore's ScopeChain class 
https://bugs.webkit.org/show_bug.cgi?id=27834
Summary [commit+] Allow custom memory allocation control for JavaScriptCore's ScopeCh...
Zoltan Horvath
Reported 2009-07-30 05:49:18 PDT
Inherits ScopeChain class from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.
Attachments
proposed patch (1.10 KB, patch)
2009-07-30 05:51 PDT, Zoltan Horvath 		oliver: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-07-30 05:51:50 PDT
Created attachment 33774 [details] proposed patch
Adam Barth
Comment 2 2009-08-01 01:19:54 PDT
Comment on attachment 33774 [details] proposed patch Clearing review flag on attachment: 33774 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/ScopeChain.h Committed r46668 M JavaScriptCore/runtime/ScopeChain.h M JavaScriptCore/ChangeLog r46668 = 90053501e66706eafcc6a1899f728634c387850f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46668
Adam Barth
Comment 3 2009-08-01 01:19:58 PDT
All reviewed patches have been landed. Closing bug.
Oliver Hunt
Comment 4 2009-08-01 13:21:32 PDT
Comment on attachment 33774 [details] proposed patch This patch needs to be rolled out - it was using placement new, ScopeChain is not a heap allocated type.
Oliver Hunt
Comment 5 2009-08-01 13:23:38 PDT
Reopening as it this patch needs to be rolled out - the bug is invalid.
Zoltan Horvath
Comment 6 2009-08-01 13:26:37 PDT
You are right! Thanks for your attention.
Mark Rowe (bdash)
Comment 7 2009-08-01 16:00:46 PDT
Rolled out in r46679.
Note You need to log in before you can comment on or make changes to this bug.