Bug 27834 - [commit+] Allow custom memory allocation control for JavaScriptCore's ScopeChain class
Summary: [commit+] Allow custom memory allocation control for JavaScriptCore's ScopeCh...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-07-30 05:49 PDT by Zoltan Horvath
Modified: 2009-08-01 16:00 PDT (History)
2 users (show)

See Also:

proposed patch (1.10 KB, patch)
2009-07-30 05:51 PDT, Zoltan Horvath
oliver: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-30 05:49:18 PDT
Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.
Comment 1 Zoltan Horvath 2009-07-30 05:51:50 PDT
Created attachment 33774 [details]
proposed patch
Comment 2 Adam Barth 2009-08-01 01:19:54 PDT
Comment on attachment 33774 [details]
proposed patch

Clearing review flag on attachment: 33774

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/ScopeChain.h
Committed r46668
	M	JavaScriptCore/runtime/ScopeChain.h
	M	JavaScriptCore/ChangeLog
r46668 = 90053501e66706eafcc6a1899f728634c387850f (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Comment 3 Adam Barth 2009-08-01 01:19:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Oliver Hunt 2009-08-01 13:21:32 PDT
Comment on attachment 33774 [details]
proposed patch

This patch needs to be rolled out - it was using placement new, ScopeChain is not a heap allocated type.
Comment 5 Oliver Hunt 2009-08-01 13:23:38 PDT
Reopening as it this patch needs to be rolled out - the bug is invalid.
Comment 6 Zoltan Horvath 2009-08-01 13:26:37 PDT
You are right! Thanks for your attention.
Comment 7 Mark Rowe (bdash) 2009-08-01 16:00:46 PDT
Rolled out in r46679.