WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278296
Make sure Markable is set when dereferencing it and getting its value
https://bugs.webkit.org/show_bug.cgi?id=278296
Summary
Make sure Markable is set when dereferencing it and getting its value
Chris Dumez
Reported
2024-08-18 15:06:20 PDT
Make sure WTF::Markable is set when dereferencing it and getting its value, similarly to what is done with std::optional. We currently have no check so you can dereference an unset Markable and get an unexpected value. This matters a lot when using Markable with ObjectIdentifier for example. ObjectIdentifier is expected to be a valid identifier, however, you can easily get can invalid ObjectIdentifier if it was stored in a Markable.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-08-18 15:08:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32363
EWS
Comment 2
2024-08-18 20:08:36 PDT
Committed
282412@main
(1b44f3a2465f): <
https://commits.webkit.org/282412@main
> Reviewed commits have been landed. Closing PR #32363 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-08-18 20:09:12 PDT
<
rdar://problem/134221754
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug