Bug 278295 – [Media] Fix -Wmissing-designated-field-initializers warnings for CoreMediaWrapped objects

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Media

[David Kilzer (:ddkilzer)]

Fix -Wmissing-designated-field-initializers warnings for CoreMediaWrapped objects.

Example warnings (not all of them):

In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:5:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h:109:5: error: missing field 'parseAdditionalFragments' initializer [-Werror,-Wmissing-designated-field-initializers]
  109 |     };
      |     ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:5:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:32:
Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.h:138:5: error: missing field 'getTrackEditCount' initializer [-Werror,-Wmissing-designated-field-initializers]
  138 |     };
      |     ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:7:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h:165:5: error: missing field 'getDependencyInfo' initializer [-Werror,-Wmissing-designated-field-initializers]
  165 |     };
      |     ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:4:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:141:5: error: missing field 'equal' initializer [-Werror,-Wmissing-designated-field-initializers]
  141 |     };
      |     ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:156:95: note: in instantiation of function template specialization 'WebKit::CoreMediaWrapped<WebKit::MediaFormatReader>::wrapperClass<104UL>' requested here
  156 |     static constexpr struct { uint8_t pad[padSize]; CMBaseClass baseClass; } baseClass { { }, wrapperClass<sizeof(Wrapped)>() };
      |                                                                                               ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:108:10: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaFormatReader>::vTable' requested here
  108 |     if (&vTable().base != wrapperVTable(baseObject))
      |          ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:5:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h:107:20: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaFormatReader>::unwrap' requested here
  107 |             return unwrap(reader)->copyTrackArray(trackArrayCopy);
      |                    ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:4:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:141:5: error: missing field 'equal' initializer [-Werror,-Wmissing-designated-field-initializers]
  141 |     };
      |     ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:156:95: note: in instantiation of function template specialization 'WebKit::CoreMediaWrapped<WebKit::MediaTrackReader>::wrapperClass<96UL>' requested here
  156 |     static constexpr struct { uint8_t pad[padSize]; CMBaseClass baseClass; } baseClass { { }, wrapperClass<sizeof(Wrapped)>() };
      |                                                                                               ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:108:10: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaTrackReader>::vTable' requested here
  108 |     if (&vTable().base != wrapperVTable(baseObject))
      |          ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:5:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:32:
Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.h:127:20: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaTrackReader>::unwrap' requested here
  127 |             return unwrap(trackReader)->getTrackInfo(trackID, mediaType);
      |                    ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:4:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:141:5: error: missing field 'equal' initializer [-Werror,-Wmissing-designated-field-initializers]
  141 |     };
      |     ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:156:95: note: in instantiation of function template specialization 'WebKit::CoreMediaWrapped<WebKit::MediaSampleCursor>::wrapperClass<96UL>' requested here
  156 |     static constexpr struct { uint8_t pad[padSize]; CMBaseClass baseClass; } baseClass { { }, wrapperClass<sizeof(Wrapped)>() };
      |                                                                                               ^
Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:108:10: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaSampleCursor>::vTable' requested here
  108 |     if (&vTable().base != wrapperVTable(baseObject))
      |          ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:7:
In file included from Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:27:
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h:131:20: note: in instantiation of member function 'WebKit::CoreMediaWrapped<WebKit::MediaSampleCursor>::unwrap' requested here
  131 |             return unwrap(sampleCursor)->copy(sampleCursorCopy);
      |                    ^
In file included from WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource60.cpp:7:
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:400:9: error: missing field 'partialSync' initializer [-Werror,-Wmissing-designated-field-initializers]
  400 |         };
      |         ^
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:304:9: note: in instantiation of function template specialization 'WebKit::MediaSampleCursor::getSyncInfo(MTPluginSampleCursorSyncInfo *)::(anonymous class)::operator()<std::pair<const WebCore::MediaSample *, const WebCore::MediaSamplesBlock::MediaSampleItem *>>' requested here
  304 |         function(*sample);
      |         ^
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:298:81: note: while substituting into a lambda expression here
  298 |     return getSampleMap([&](SampleMap& samples, bool hasAllSamples) -> OSStatus {
      |                                                                                 ^
Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:397:12: note: in instantiation of function template specialization 'WebKit::MediaSampleCursor::getMediaSample<(lambda at Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:397:27)>' requested here
  397 |     return getMediaSample([&](auto& sample) {
      |            ^
7 errors generated.

[Radar WebKit Bug Importer]

<rdar://problem/134205424>

[David Kilzer (:ddkilzer)]

Pull request: https://github.com/WebKit/WebKit/pull/32362

[David Kilzer (:ddkilzer)]

Dupe of Bug 278596 as that fix removed all the code changed by this fix.

*** This bug has been marked as a duplicate of bug 278596 ***