WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278248
Make ObjectIdentifier / AtomicObjectIdentifier non-nullable by default
https://bugs.webkit.org/show_bug.cgi?id=278248
Summary
Make ObjectIdentifier / AtomicObjectIdentifier non-nullable by default
Chris Dumez
Reported
2024-08-16 12:40:45 PDT
Make ObjectIdentifier / AtomicObjectIdentifier non-nullable by default, meaning that they do not have a default constructor that constructs an "invalid" identifier. This forces call sites to use Markable / std::optional and the identifier is missing, we can actually get sent over IPC.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-08-16 12:44:20 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32312
EWS
Comment 2
2024-08-16 20:00:46 PDT
Committed
282385@main
(e596a69244f6): <
https://commits.webkit.org/282385@main
> Reviewed commits have been landed. Closing PR #32312 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-08-16 20:01:14 PDT
<
rdar://problem/134106203
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug