WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
278219
Make NavigationIdentifier non-nullable
https://bugs.webkit.org/show_bug.cgi?id=278219
Summary
Make NavigationIdentifier non-nullable
Chris Dumez
Reported
2024-08-15 22:21:16 PDT
Make NavigationIdentifier non-nullable, forcing callers to use Markable/std::optional when there is no identifier. This makes it clearer when the identifier can be missing or not. It is also more compatible with our IPC layer which rejects sending a null ObjectIdentifier.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-08-15 22:49:39 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32290
EWS
Comment 2
2024-08-16 11:23:47 PDT
Committed
282359@main
(54e56ff12891): <
https://commits.webkit.org/282359@main
> Reviewed commits have been landed. Closing PR #32290 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-08-16 11:24:14 PDT
<
rdar://problem/134070906
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug