Bug 27820 – [commit+] Adding layout test for Unicode in <script> tag attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Evan Martin]

Chrome bug here:
http://code.google.com/p/chromium/issues/detail?id=17958

This bug is for the regression test.

[Evan Martin]

Created attachment 33750 [details]
wip


---
 2 files changed, 10 insertions(+), 0 deletions(-)

[Evan Martin]

Hopefully someone who monitors my bugts here will take pity on me and help me figure out where this test belongs.

The interesting part of the call stack of the crash is

(WebCore::ScriptElementData::shouldExecuteAsJavaScript const v+0x6e) [0x8d073ae]
(WebCore::HTMLScriptElement::shouldExecuteAsJavaScript const v+0x14) [0x930ac34]
(WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State)+0x237) [0x8dbbe11]

Does that count as parser?  That's why my patch does.

[Evan Martin]

(Will upload a changelog if the basic idea looks ok -- this is the first layout test I've contributed.)

[Adam Barth]

Comment on attachment 33750 [details]
wip

Yeah, this looks good.  We just need a ChangeLog.  WebKitTools/Scripts/prepare-ChangeLog can help you with that.

[Evan Martin]

Created attachment 33831 [details]
patch with changelog


---
 3 files changed, 20 insertions(+), 0 deletions(-)

[Adam Barth]

Comment on attachment 33831 [details]
patch with changelog

Awesome!  Thanks for the patch.

[Adam Barth]

Comment on attachment 33831 [details]
patch with changelog

Clearing review flag on attachment: 33831

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/parser/smart-quotes-in-tag-expected.txt
	A	LayoutTests/fast/parser/smart-quotes-in-tag.html
Committed r46665
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/parser/smart-quotes-in-tag.html
	A	LayoutTests/fast/parser/smart-quotes-in-tag-expected.txt
r46665 = 026f80cb444acb568910eac8f412de21cd9dbda5 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46665

[Adam Barth]

All reviewed patches have been landed.  Closing bug.