Bug 27816 – WINCE PORT: some files modified for WINCE build

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Yong Li]

WebCore/accessibility/AccessibilityObject.h
WebCore/page/win/EventHandlerWin.cpp
WebCore/platform/win/BitmapInfo.h
WebCore/platform/win/PlatformMouseEventWin.cpp
WebCore/platform/win/PlatformScreenWin.cpp
WebCore/platform/win/PopupMenuWin.cpp

[Yong Li]

Created attachment 33741 [details]
the patch

About BitmapInfo: We started using class BitmapInfo in WINCE port at least 1 year ago. Later, we found that webkit upstream added BitmapInfo.h for win32 port. However, the usage is different. Probably we should restructure it to make WINCE and WIN32 share a same BitmapInfo class? I'm not sure if it's good for win32 port.

[Yong Li]

Created attachment 33743 [details]
updated patch

[George Staikos]

Comment on attachment 33741 [details]
the patch

Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at least one place.


>  class BitmapInfo: public BITMAPINFO

   Space missing


The changes in ~PopupMenu should probably be submitted separately.  They look generic.

[George Staikos]

Comment on attachment 33743 [details]
updated patch

See previous comments

[Yong Li]

(In reply to comment #3)
> (From update of attachment 33741 [details])
> Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at
> least one place.
> 
> 
> >  class BitmapInfo: public BITMAPINFO
> 
>    Space missing
>
o.k.

> 
> The changes in ~PopupMenu should probably be submitted separately.  They look
> generic.

there's another generic one (ReleaseDC) :)

[Yong Li]

Created attachment 33780 [details]
updatd (PopupMenuWin.cpp)

[George Staikos]

Committed, r46591