Bug 27816 - WINCE PORT: some files modified for WINCE build
Summary: WINCE PORT: some files modified for WINCE build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 23154
  Show dependency treegraph
 
Reported: 2009-07-29 14:02 PDT by Yong Li
Modified: 2009-07-30 11:26 PDT (History)
2 users (show)

See Also:


Attachments
the patch (12.66 KB, patch)
2009-07-29 14:14 PDT, Yong Li
staikos: review-
Details | Formatted Diff | Diff
updated patch (12.62 KB, patch)
2009-07-29 14:25 PDT, Yong Li
staikos: review-
Details | Formatted Diff | Diff
updatd (PopupMenuWin.cpp) (9.31 KB, patch)
2009-07-30 07:56 PDT, Yong Li
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2009-07-29 14:02:42 PDT
WebCore/accessibility/AccessibilityObject.h
WebCore/page/win/EventHandlerWin.cpp
WebCore/platform/win/BitmapInfo.h
WebCore/platform/win/PlatformMouseEventWin.cpp
WebCore/platform/win/PlatformScreenWin.cpp
WebCore/platform/win/PopupMenuWin.cpp
Comment 1 Yong Li 2009-07-29 14:14:47 PDT
Created attachment 33741 [details]
the patch

About BitmapInfo: We started using class BitmapInfo in WINCE port at least 1 year ago. Later, we found that webkit upstream added BitmapInfo.h for win32 port. However, the usage is different. Probably we should restructure it to make WINCE and WIN32 share a same BitmapInfo class? I'm not sure if it's good for win32 port.
Comment 2 Yong Li 2009-07-29 14:25:16 PDT
Created attachment 33743 [details]
updated patch
Comment 3 George Staikos 2009-07-29 14:28:58 PDT
Comment on attachment 33741 [details]
the patch

Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at least one place.


>  class BitmapInfo: public BITMAPINFO

   Space missing


The changes in ~PopupMenu should probably be submitted separately.  They look generic.
Comment 4 George Staikos 2009-07-29 14:29:39 PDT
Comment on attachment 33743 [details]
updated patch

See previous comments
Comment 5 Yong Li 2009-07-29 14:33:46 PDT
(In reply to comment #3)
> (From update of attachment 33741 [details])
> Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at
> least one place.
> 
> 
> >  class BitmapInfo: public BITMAPINFO
> 
>    Space missing
>
o.k.

> 
> The changes in ~PopupMenu should probably be submitted separately.  They look
> generic.

there's another generic one (ReleaseDC) :)
Comment 6 Yong Li 2009-07-30 07:56:53 PDT
Created attachment 33780 [details]
updatd (PopupMenuWin.cpp)
Comment 7 George Staikos 2009-07-30 11:26:03 PDT
Committed, r46591