RESOLVED FIXED278094
[WPE][Skia] Address pending review comments of 282223@main 
https://bugs.webkit.org/show_bug.cgi?id=278094
Summary [WPE][Skia] Address pending review comments of 282223@main
Miguel Gomez
Reported 2024-08-14 03:03:39 PDT
There a couple of review comments left out for that commit, so fix them here: - rename the env var from WEBKIT_MSAA_SAMPLE_COUNT to WEBKIT_SKIA_MSAA_SAMPLE_COUNT. - don't try to create the SkSurface if the env var value is 0 or 1, as this means disabling msaa. - move the call to initializeMSAASampleCount() to the if that checks whether we have a skia context. - make PlatformDisplay::msaaSampleCount() and SkiaGLContext::sampleCount() const.
Attachments
Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2024-08-14 03:08:47 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32187
EWS
Comment 2 2024-08-14 08:51:34 PDT
Committed 282233@main (fc56b1c7abd3): <https://commits.webkit.org/282233@main> Reviewed commits have been landed. Closing PR #32187 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.