Bug 278042 – [text-box] Add support for text-box shorthand

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

https://drafts.csswg.org/css-inline-3/#text-box-shorthand

[zalan]

Created attachment 472148 [details]
Patch

[zalan]

Created attachment 472153 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 472153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=472153&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:2626
> +        if (RefPtr trimValue = consumeIdent<CSSValueNone, CSSValueTrimStart, CSSValueTrimEnd, CSSValueTrimBoth>(m_range)) {

You can set `"parser-exported": true` in CSSProperties.json and use the generated `CSSPropertyParsing::consumeTextBoxTrim` to avoid duplication.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:2661
> +    auto consumeTextBoxEdge = [&] {
> +        if (RefPtr<CSSValue> textBoxEdge = consumeTextEdge(CSSPropertyTextBoxEdge, m_range)) {
> +            addProperty(CSSPropertyTextBoxEdge, CSSPropertyTextBox, WTFMove(textBoxEdge), important);
> +            return true;
> +        }
> +        return false;
> +    };
> +    auto hasTextBoxEdge = consumeTextBoxEdge();
> +
> +    if (hasTextBoxTrim && hasTextBoxEdge)
> +        return m_range.atEnd();
> +
> +    if (!hasTextBoxTrim && !hasTextBoxEdge)
> +        return false;
> +
> +    if (hasTextBoxTrim) {
> +        if (!consumeTextBoxEdge()) {
> +            // Omitting the text-box-edge value sets it to auto (the initial value)
> +            addProperty(CSSPropertyTextBoxEdge, CSSPropertyTextBox, CSSValueList::createSpaceSeparated(CSSPrimitiveValue::create(CSSValueAuto), CSSPrimitiveValue::create(CSSValueAuto)), important);
> +        }
> +        return true;
> +    }
> +
> +    if (!consumeTextBoxTrim()) {
> +        // Omitting the text-box-trim value sets it to both (not the initial value)
> +        addProperty(CSSPropertyTextBoxTrim, CSSPropertyTextBox, CSSPrimitiveValue::create(CSSValueTrimBoth), important);
> +    }
> +    return true;

You could be doing a loop like `CSSPropertyParser::consumeTextWrapShorthand` which would be more elegant than trying to repeat parsing on both sides.

[zalan]

Created attachment 472160 [details]
Patch

[zalan]

Created attachment 472161 [details]
Patch

[zalan]

Created attachment 472173 [details]
[fast-cq]Patch

[EWS]

Committed 282282@main (c00fddd06efe): <https://commits.webkit.org/282282@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 472173 [details].

[Radar WebKit Bug Importer]

<rdar://problem/133942602>