RESOLVED FIXED 27804
[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
https://bugs.webkit.org/show_bug.cgi?id=27804
Summary [Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslEr...
Antonio Gomes
Reported 2009-07-29 08:20:46 PDT
follow up bug of work done in bug 25867 see https://bugs.webkit.org/show_bug.cgi?id=25867#c19 and bug 27444 for problem description.
Attachments
fix (1.62 KB, patch)
2009-07-29 10:59 PDT, Antonio Gomes
no flags
v0.2 - fix + autotest (4.94 KB, patch)
2009-08-04 07:54 PDT, Antonio Gomes
no flags
v0.3 - fix + autotest (4.94 KB, patch)
2009-08-04 08:12 PDT, Antonio Gomes
hausmann: review+
Antonio Gomes
Comment 1 2009-07-29 10:59:30 PDT
Eric Seidel (no email)
Comment 2 2009-07-31 15:17:49 PDT
Comment on attachment 33724 [details] fix Can we test this? Maybe with an http test?
Antonio Gomes
Comment 3 2009-08-03 12:02:05 PDT
Comment on attachment 33724 [details] fix clearing review. as per eric's suggetion i will add a autotest (not http test)
Antonio Gomes
Comment 4 2009-08-04 07:54:01 PDT
Created attachment 34062 [details] v0.2 - fix + autotest added an autotest for the case. in the autotest, it forces a SSLError to be catch and check if the requestedUrl value matches the expected.
Antonio Gomes
Comment 5 2009-08-04 08:12:27 PDT
Created attachment 34063 [details] v0.3 - fix + autotest same patch as 0.2 but fixed gcc warning and updated to ToT.
Simon Hausmann
Comment 6 2009-08-04 08:18:15 PDT
Comment on attachment 34063 [details] v0.3 - fix + autotest r=me
Antonio Gomes
Comment 7 2009-08-04 08:39:02 PDT
r46767 thanks simon
Note You need to log in before you can comment on or make changes to this bug.