Bug 27804 - [Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
Summary: [Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslEr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-29 08:20 PDT by Antonio Gomes
Modified: 2009-08-04 08:39 PDT (History)
2 users (show)

See Also:


Attachments
fix (1.62 KB, patch)
2009-07-29 10:59 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
v0.2 - fix + autotest (4.94 KB, patch)
2009-08-04 07:54 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
v0.3 - fix + autotest (4.94 KB, patch)
2009-08-04 08:12 PDT, Antonio Gomes
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2009-07-29 08:20:46 PDT
follow up bug of work done in bug 25867

see https://bugs.webkit.org/show_bug.cgi?id=25867#c19 and bug 27444 for problem description.
Comment 1 Antonio Gomes 2009-07-29 10:59:30 PDT
Created attachment 33724 [details]
fix
Comment 2 Eric Seidel (no email) 2009-07-31 15:17:49 PDT
Comment on attachment 33724 [details]
fix

Can we test this?  Maybe with an http test?
Comment 3 Antonio Gomes 2009-08-03 12:02:05 PDT
Comment on attachment 33724 [details]
fix

clearing review.

as per eric's suggetion i will add a autotest (not http test)
Comment 4 Antonio Gomes 2009-08-04 07:54:01 PDT
Created attachment 34062 [details]
v0.2 - fix + autotest

added an autotest for the case.

in the autotest, it forces a SSLError to be catch and check if the requestedUrl value matches the expected.
Comment 5 Antonio Gomes 2009-08-04 08:12:27 PDT
Created attachment 34063 [details]
v0.3 - fix + autotest

same patch as 0.2 but fixed gcc warning and updated to ToT.
Comment 6 Simon Hausmann 2009-08-04 08:18:15 PDT
Comment on attachment 34063 [details]
v0.3 - fix + autotest

r=me
Comment 7 Antonio Gomes 2009-08-04 08:39:02 PDT
r46767

thanks simon