Bug 27798 – [chromium] Media control panel for <video> in MediaDocument is mis-placed

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Hin-Chung Lam]

Created attachment 33703 [details]
overlap

When a video file is loaded by MediaDocument, <video> is used to play the video file, the control panel is misplaced and overlaps with the video by 16 pixels.

[Hin-Chung Lam]

Created attachment 33706 [details]
patch

[David Levin]

Comment on attachment 33706 [details]
patch

> Index: WebCore/ChangeLog

> [phone]  Alpha Lam  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).

This should be added to the changelog:

  Media control panel for <video> in MediaDocument is mis-placed
  https://bugs.webkit.org/show_bug.cgi?id=27798

If you can use prepare-ChangeLog --bug #, this will be set-up for you.

[David Levin]

Committed as http://trac.webkit.org/changeset/46534

[Ami Fischman]

Created attachment 82363 [details]
Patch

[Ami Fischman]

Motivation for the patch I just attached is the linked chromium bug on test_shell.  Hopefully merely commenting here will reopen this bug.  If using a new bug is preferred please let me know.

[David Levin]

Comment on attachment 82363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82363&action=review

A new bug is preferred for new work/patches -- otherwise it can be confusing to sort through the comments (which pertain to the current patch and which pertain to the old patch).

> Source/WebCore/ChangeLog:13
> +        No new tests. (OOPS!)

This line needs to be replaced :)

A few choices:
1. Indicate what test you're adding.
2. Indicate what test covers the functionality.
3. Indicate why a test isn't necessary (No new functionality, so no new tests.) (Hint that isn't the case here because you're changing something that is visible.)
4. Indicate why a test isn't possible (You should add functionality to dumprendertree if necessary to test, so this is almost never the correct answer.)

[Ami Fischman]

@levin: thanks for the info & comments.  I opened bug 54436 and attached an updated patch which contains a layout test that asserts the new behavior.