RESOLVED FIXED 277900
[CMake] Revamp detection of _Float16 in Linux 
https://bugs.webkit.org/show_bug.cgi?id=277900
Summary [CMake] Revamp detection of _Float16 in Linux
Diego Pino
Reported 2024-08-10 01:35:21 PDT
The build of WebKitGTK and WPE started failing in many Linux systems after 281895@main, due to lack of _Float16 support. https://build.webkit.org/#/builders/1060/builds/2320 Changeset 281937@main fixed partially the detection of _Float16 support for some systems, but it didn't fix it for all. For instance, in the case of the WPE-Linux-ARM64-bit-Release-Debian-Stable-Build bot, the systems has the __FLT16_MANT_DIG__ macro defined but still lacks _Float16 support. Changeset 281940@main attempted to fix this later case, but it broke the build for non CMake system so the patch was reverted. This new attempt implements _Float16 support via CMake only for Linux systems, while it leaves the detection via macro flags for other systems that are not Linux.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2024-08-10 01:40:50 PDT
Pull request: https://github.com/webkit/webkit/pull/31984
EWS
Comment 2 2024-08-12 13:10:44 PDT
Committed 282131@main (974b49251d28): <https://commits.webkit.org/282131@main> Reviewed commits have been landed. Closing PR #31984 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-08-12 13:11:16 PDT
<rdar://problem/133707090>
Note You need to log in before you can comment on or make changes to this bug.