Bug 27786 - [WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
Summary: [WML] WML*Element classes mostly implement insertedIntoDocument(), not remove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393
  Show dependency treegraph
 
Reported: 2009-07-28 17:09 PDT by Nikolas Zimmermann
Modified: 2009-07-28 17:50 PDT (History)
2 users (show)

See Also:


Attachments
Initial patch (19.10 KB, patch)
2009-07-28 17:17 PDT, Nikolas Zimmermann
manyoso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2009-07-28 17:09:28 PDT
WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument().
The only case where this is relevant in WML is error handling. The parsed WML tree fragment is inserted in an XHTML compound error document. This requires removedFromDocument() to be correctly implemented otherwhise we run into trouble (visible when using run-webkit-tests fast/wml --random).
Comment 1 Nikolas Zimmermann 2009-07-28 17:17:20 PDT
Created attachment 33681 [details]
Initial patch
Comment 2 Adam Treat 2009-07-28 17:33:25 PDT
Comment on attachment 33681 [details]
Initial patch

After Niko walked me through it over chat I can't find anything wrong.  Drats :)
Comment 3 Nikolas Zimmermann 2009-07-28 17:50:21 PDT
Landed in r46510.