Bug 27779 – WINCE PORT: modified graphics files

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Yong Li]

patch is comming

[Yong Li]

Created attachment 33668 [details]
the patch

[Yong Li]

Created attachment 33669 [details]
remove an unnecessary line

[George Staikos]

Comment on attachment 33669 [details]
remove an unnecessary line

A lot of the things conditionally removed in this patch look suspicious to me.  Are you sure they're correct?

[Yong Li]

(In reply to comment #3)
> (From update of attachment 33669 [details])
> A lot of the things conditionally removed in this patch look suspicious to me. 
> Are you sure they're correct?

Which things do you mean?

I didn't see many things removed. We don't have PlatformGradient.

[George Staikos]

Is it possible to refactor this into a PlatformGradient class that doesn't do any "platform" calls so we still fit within the framework?

[Yong Li]

(In reply to comment #5)
> Is it possible to refactor this into a PlatformGradient class that doesn't do
> any "platform" calls so we still fit within the framework?

Yes. We can leave a void* for it. just a waste of 4 bytes. I'll clean it up

[Yong Li]

Created attachment 33719 [details]
remove unnecessary changes

[Yong Li]

Created attachment 33731 [details]
add some comments for removed ASSERT

[George Staikos]

Comment on attachment 33731 [details]
add some comments for removed ASSERT

Still more ifdef than I'd like to see but I think it's ok for now.  Unfortunately WinCE doesn't make this easy.

[George Staikos]

Comment on attachment 33731 [details]
add some comments for removed ASSERT

        
> +#if !PLATFORM(WINCE) || PLATFORM(QT)
>          PlatformGraphicsContext* platformContext() const;
> +#endif
> +
> +        const Font& font() const;
> +        void setFont(const Font&);

  I think we have a problem here.  Why are these unconditionally added?

  In retrospect I think we need more cleanup.

[Yong Li]

(In reply to comment #10)
> (From update of attachment 33731 [details])
> 
> > +#if !PLATFORM(WINCE) || PLATFORM(QT)
> >          PlatformGraphicsContext* platformContext() const;
> > +#endif
> > +
> > +        const Font& font() const;
> > +        void setFont(const Font&);
> 
>   I think we have a problem here.  Why are these unconditionally added?
> 
>   In retrospect I think we need more cleanup.

Hm... we don't use them. probably it's a garbage from very old revision. I'll do do more cleanup.

[Yong Li]

Created attachment 33777 [details]
more clean up

[George Staikos]

Committed r46590