Bug 27767 - Kill the annoying (and misunderstandable) LEAK messages in debug mode
Summary: Kill the annoying (and misunderstandable) LEAK messages in debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-07-28 06:49 PDT by Zoltan Herczeg
Modified: 2010-03-08 06:37 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (2.65 KB, patch)
2009-07-28 06:53 PDT, Zoltan Herczeg
no flags Details | Formatted Diff | Diff
propsed patch v2 (2.80 KB, patch)
2009-07-28 23:39 PDT, Zoltan Herczeg
no flags Details | Formatted Diff | Diff
propsed patch v3 (1.79 KB, patch)
2009-07-29 01:30 PDT, Zoltan Herczeg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2009-07-28 06:49:43 PDT
When QtLauncher quits in debug mode, it yields several LEAK messages. This is confusing, since one could think these are real leaks, and QtLauncher has difficulties freeing memory blocks. This patch mimics the mac version.
Comment 1 Zoltan Herczeg 2009-07-28 06:53:11 PDT
Created attachment 33624 [details]
proposed patch
Comment 2 Kenneth Rohde Christiansen 2009-07-28 09:00:29 PDT
"Kill the LEAK messages in Debug mode" for me sounds like you just removed the messages, but that is not actually what you did. Could you please make the ChangeLog more descriptive?
Comment 3 Zoltan Herczeg 2009-07-28 23:39:51 PDT
Created attachment 33696 [details]
propsed patch v2
Comment 4 Zoltan Herczeg 2009-07-29 01:30:04 PDT
Created attachment 33700 [details]
propsed patch v3
Comment 5 Simon Hausmann 2009-07-29 01:34:04 PDT
Comment on attachment 33700 [details]
propsed patch v3

r=me
Comment 6 Kenneth Rohde Christiansen 2009-07-29 05:34:52 PDT
You forgot to say that you landed this!, please clear the patch review state.