RESOLVED FIXED277661
WebCoreAVFResourceLoader may give more data than requested. 
https://bugs.webkit.org/show_bug.cgi?id=277661
Summary WebCoreAVFResourceLoader may give more data than requested.
Jean-Yves Avenard [:jya]
Reported 2024-08-05 17:46:47 PDT
Found by code review. https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm#432-446 If the AVAsset requested N bytes and the server responded with X bytes, where X >= N ; we will pass X bytes to the DataRequest. Additionally, under such circumstances, `bytesToUse` is greater than `remainingLength` and so the instruction `remainingLength -= bytesToUse;` to overflow being an unsigned. And so we will incorrectly expect more data to be received https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm#459-461
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-05 17:47:03 PDT
<rdar://problem/133256334>
Jean-Yves Avenard [:jya]
Comment 2 2024-08-05 18:53:36 PDT
Pull request: https://github.com/WebKit/WebKit/pull/31763
EWS
Comment 3 2025-10-09 22:26:50 PDT
Committed 301298@main (37c2e6ab592c): <https://commits.webkit.org/301298@main> Reviewed commits have been landed. Closing PR #31763 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.