WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
277660
Use an enum class for CSSValue Type
https://bugs.webkit.org/show_bug.cgi?id=277660
Summary
Use an enum class for CSSValue Type
zak ridouh
Reported
2024-08-05 17:42:01 PDT
We should use an enum class for the different types of CSSValues so we don't have to repeat "Class" in every name. We could even use the new `using enum`, so we don't need the identifier in front of each enum. Relevant files:
https://github.com/WebKit/WebKit/blob/fbf46d69fa4deb0bad4471e749bf2349eb353356/Source/WebCore/css/CSSValue.h#L212
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-08-05 17:42:12 PDT
<
rdar://problem/133256102
>
Nathan Solomon
Comment 2
2024-08-19 11:57:03 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/32401
EWS
Comment 3
2024-09-12 09:58:03 PDT
Committed
283564@main
(81dfdabf3b60): <
https://commits.webkit.org/283564@main
> Reviewed commits have been landed. Closing PR #32401 and removing active labels.
EWS
Comment 4
2024-09-25 16:18:25 PDT
Committed
283286.138@safari-7620-branch
(9e18fa6b7839): <
https://commits.webkit.org/283286.138@safari-7620-branch
> Reviewed commits have been landed. Closing PR #1908 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug