Bug 27766 – Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of InspectorJSONObject

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Currently, ScriptObject/ScriptArray require ScriptState for any operation on them. InspectorJSONObject is a ScriptObject convenience wrapper that lives is WebCore/inspector and encapsulates ScriptState. Its name is a bit confusing: it is not a real JSONObject, it is just an object that is intended to be stringified. This change encapsulates ScriptState in the ScriptObject itself and gets rid of InspectorJSONObject.

[Pavel Feldman]

Created attachment 33623 [details]
patch

[Dimitri Glazkov (Google)]

Comment on attachment 33623 [details]
patch

r=me.

This limits usefulness of the ScriptObject, but sure makes the code more legible/pretty. In any case, we could always add ScriptObject::setState(ScriptState*) later if we need it.

[Pavel Feldman]

	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.gypi
	M	WebCore/bindings/js/ScriptObject.h
	M	WebCore/bindings/js/ScriptObject.cpp
	M	WebCore/bindings/js/ScriptArray.h
	M	WebCore/bindings/js/ScriptArray.cpp
	M	WebCore/bindings/js/ScriptFunctionCall.cpp
	M	WebCore/bindings/js/ScriptObjectQuarantine.cpp
	M	WebCore/bindings/v8/ScriptObject.h
	M	WebCore/bindings/v8/ScriptObject.cpp
	M	WebCore/bindings/v8/ScriptArray.h
	M	WebCore/bindings/v8/ScriptArray.cpp
	M	WebCore/bindings/v8/ScriptFunctionCall.cpp
	M	WebCore/bindings/v8/ScriptObjectQuarantine.cpp
	D	WebCore/inspector/InspectorJSONObject.cpp
	D	WebCore/inspector/InspectorJSONObject.h
	M	WebCore/inspector/InspectorDOMStorageResource.cpp
	M	WebCore/inspector/InspectorDatabaseResource.cpp
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCoreSources.bkl
r46490 = 86e33496b1bb9f675699ccdb697950e607d02c5e (trunk)

[Timothy Hatcher]

Thanks for doing this! InspectorJSONObject was confusing many people…